[ 
https://issues.apache.org/jira/browse/SLIDER-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092640#comment-14092640
 ] 

Steve Loughran commented on SLIDER-306:
---------------------------------------

thanks for this!

I've patched a slightly modified version in to a branch 
{{feature/SLIDER-306_Slider_list_command_live_and_history_options}} and done an 
initial review. I've also tweaked the manpage.md (which lives in slider's svn 
for automated site generation). 

But I haven't yet committed this as we have to 
# define what the policy on {{list clustername --history}} should be
# add some tests.

For policy, {{slider list <clustername}} currently only succeeds if the cluster 
is live. I think for {{--history}}, we should have the same policy: the cluster 
name must be in the history list. And for   {{--live --history}} it must exist 
in either the live or historical list.

Test wise, we need something which does the core lists (no args, each arg, both 
arg), with and without a cluster name, for the cluster name looking for the 
relevant status code.

{{TestStandaloneAMDestroy}} would be the test to patch for this, as it is 
creating and destroying app masters...it will go from "unknown" to live to 
historical and back to live again

> Slider list command live and history options
> --------------------------------------------
>
>                 Key: SLIDER-306
>                 URL: https://issues.apache.org/jira/browse/SLIDER-306
>             Project: Slider
>          Issue Type: Improvement
>          Components: client
>            Reporter: Vasanth kumar RJ
>            Priority: Minor
>         Attachments: SLIDER-306-002.patch, SLIDER-306.patch
>
>
> Currently slider list command shows all the finished and running instances 
> which is not order on any field. 
> Patch introduced live and history option to view live instances and finished 
> instances.
> When listing all instances or only history/finished instances, first shows 
> finished instance ordered by finish time and then show running instances 
> ordered by start time.
> //List only live
> >slider list --live
> //List only history or finished
> >slider list --history
> >slider list c1 --history



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to