In that case users will have to set these properties but now they also need to un-comment it. So we are adding one more step while editing.
On Thu, Sep 18, 2014 at 2:02 PM, Steve Loughran <[email protected]> wrote: > big issue is "what if there is no hadoop conf dir", such as on a client > system? > > On 18 September 2014 20:31, Sumit Mohanty <[email protected]> > wrote: > > > I am thinking of commenting out the following in the default > > slider-client.xml. We have added support for setting JAVA_HOME and > > HADOOP_CONF_DIR and so when the later is not set then users are expected > to > > uncomment this. > > > > Do you think there are tests that will get affected by it? > > > > <!-- > > <property> > > <name>yarn.application.classpath</name> > > > > > > > <value>/etc/hadoop/conf,/usr/lib/hadoop/*,/usr/lib/hadoop/lib/*,/usr/lib/hadoop-hdfs/*,/usr/lib/hadoop-hdfs/lib/*,/usr/lib/hadoop-yarn/*,/usr/lib/hadoop-yarn/lib/*,/usr/lib/hadoop-mapreduce/*,/usr/lib/hadoop-mapreduce/lib/*</value> > > </property> > > > > <property> > > <name>yarn.resourcemanager.address</name> > > <value>@RM-ADDR</value> > > </property> > > > > <property> > > <name>yarn.resourcemanager.scheduler.address</name> > > <value>@RM-SCHEDULER-ADDR</value> > > </property> > > > > <property> > > <name>fs.defaultFS</name> > > <value>@FILESYSTEM</value> > > </property> > > --> > > > > -- > > CONFIDENTIALITY NOTICE > > NOTICE: This message is intended for the use of the individual or entity > to > > which it is addressed and may contain information that is confidential, > > privileged and exempt from disclosure under applicable law. If the reader > > of this message is not the intended recipient, you are hereby notified > that > > any printing, copying, dissemination, distribution, disclosure or > > forwarding of this communication is strictly prohibited. If you have > > received this communication in error, please contact the sender > immediately > > and delete it from your system. Thank You. > > > > -- > CONFIDENTIALITY NOTICE > NOTICE: This message is intended for the use of the individual or entity to > which it is addressed and may contain information that is confidential, > privileged and exempt from disclosure under applicable law. If the reader > of this message is not the intended recipient, you are hereby notified that > any printing, copying, dissemination, distribution, disclosure or > forwarding of this communication is strictly prohibited. If you have > received this communication in error, please contact the sender immediately > and delete it from your system. Thank You. > -- thanks Sumit
