[ 
https://issues.apache.org/jira/browse/SLIDER-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291784#comment-14291784
 ] 

Steve Loughran commented on SLIDER-745:
---------------------------------------

from billie on vote

{code}
-1:

The release number doesn't have incubating (e.g. 0.61.0-incubating), so
"incubating" is missing from the artifact file names.  I've checked over
slider-0.61.0-source-release.tar.gz and its contents look okay.  One weird
thing is it untars to apache-slider-*.  This is because we're setting the
finalName in the pom, but maven doesn't get around to renaming the tarball
before deploying it.  We could consider not specifying the finalName so
that the untarred directory matches the tarball name.

Another issue is that we're releasing binary artifacts now, so we have to
update their license and notice for the bundled jars.  The
slider-assembly-0.61.0-all.tar.gz tarball is just copying the license from
the top level.  It doesn't have a notice file.  The
slider-agent-0.61.0.tar.gz tarball has neither license nor notice.  The top
level license and notice do cover the agent's dependencies, so we could
just copy those into that artifact if we wanted.
These tarballs also need disclaimer files.

The command logger tarball and zip are also missing these files.  It would
be nice if we could just release slider-core and slider-agent, maybe
slider-assembly, and not deploy anything else.  I could help try to make
the maven profiles do that, if we want it to work that way.  (If we skip
slider-assembly, we won't even have to make an updated license and notice
for it ...)
{code}

> release slider 0.61 with mvn artifacts
> --------------------------------------
>
>                 Key: SLIDER-745
>                 URL: https://issues.apache.org/jira/browse/SLIDER-745
>             Project: Slider
>          Issue Type: Task
>          Components: build
>    Affects Versions: Slider 0.60
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>             Fix For: Slider 0.61
>
>         Attachments: selective-release-of-modules.patch
>
>   Original Estimate: 8h
>          Time Spent: 61h
>  Remaining Estimate: 0h
>
> # Backport SLIDER-671 changes to slider-0.60 branch
> # Release slider 0.61 with mvn artifacts published
> This will be purely 0.60 with the build changes; no other fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to