Agree with Steve. This test case failure is not one of the partial merge issues we saw previously
To fix it: The simplest fix would be checking if actionQueue is created in controller or not, just for fixing the test case. It also doesn't break the protocol: actionQueue is not created until controller.run() Please let me know what you think Thank you ________________________________________ From: Steve Loughran <[email protected]> Sent: Tuesday, October 13, 2015 9:17 AM To: [email protected] Subject: Re: Slider-develop - Build # 716 - Still Failing > On 12 Oct 2015, at 19:45, Apache Jenkins Server <[email protected]> > wrote: > > The Apache Jenkins build system has built Slider-develop (build #716) > > Status: Still Failing > > Check console output at https://builds.apache.org/job/Slider-develop/716/ to > view the results. looks like a pytest failure ====================================================================== ERROR: test_signal_handler (TestMain.TestMain) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/jenkins/jenkins-slave/workspace/Slider-develop/slider-agent/src/test/python/mock/mock.py", line 1199, in patched return func(*args, **keywargs) File "/home/jenkins/jenkins-slave/workspace/Slider-develop/slider-agent/src/test/python/agent/TestMain.py", line 60, in test_signal_handler main.signal_handler("signum", "frame") File "/home/jenkins/jenkins-slave/workspace/Slider-develop/slider-agent/src/main/python/agent/main.py", line 59, in signal_handler tmpdir = controller.actionQueue.dockerManager.stop_container() AttributeError: 'Controller' object has no attribute 'actionQueue' Looking at the code, Controller. only gets an actionQueue in its run() method, so maybe there's a race condition —if the stop() operation kicks in too early, there's no field to stop. Filed as SLIDER-946
