-0 Agree with Josh.
1. Lets fix copyright year in NOTICE, add DEPENDENCIES to the rat exclusion list and remove all pom.xml.versionBackup files 2. After the above fixes we need to create a new release candidate with version 0.81.1-incubating and a new tag slider-0.81.1-incubating (note it is 0.81.1 instead of 0.81.0). We can do all this work in the same branch "branches/branch-0.81". However let¹s make sure that the new tag slider-0.81.1-incubating and branches/branch-0.81 eventually have the same SHA. 3. After taking care of 1 and 2 let¹s send out a new vote for 0.81.1 4. Let¹s file a Slider bug to remove busy.gif and hadoop-st.png from develop branch such that they get cleaned up for next release 5. Let¹s also capture in the bug opened in step 4 above to remove copyright lines from the license headers of python-wrap and storm-slider Additionally, the following were tested and found ok - 1. Verified pgp 2. Verified md5s & shas of tar and zip 3. Built from source (from tar and zip) 4. Rat check ok (except for 1 file, DEPENDENCIES - which will be taken care of in next release) 5. Ran unit tests successfully (takes about 22 mins in my local mac) -Gour On 10/21/15, 10:22 AM, "Josh Elser" <[email protected]> wrote: >-0 > >Things I think should be fixed now: > >* There's some confusion with the Git tag and the SHA1. The SHA1 appears >to be what was built, but the tag (0.81.0-incubating doesn't exist, so >assuming you meant slider-0.81.0-incubating) doesn't match the SHA1 >(it's at 342061f7ca5afb55f172b8d4a432497a8f8b2560 instead of >38decaa05de8d962053e47040bab910cdb00f04d). > >* source tarball contains pom.xml.versionBackup files. I'd assume they >were erroneously included. > >* Copyright years in NOTICE appear incorrect. Should be 2014-2015, not >2015-2016. > >Other things I think we should fix for the next release: > >* I don't see any copyright notice for >./slider-core/src/main/resources/webapps/static/busy.gif. Looks like it >came in during the initial import. Unless Steve happened to make it or >remembers where it came from, there's some concern about someone else >owning it. It also doesn't appear to be used (grep doesn't find any >references to it, anyways), so perhaps it can just be deleted? > >* ./slider-core/src/main/resources/webapps/static/hadoop-st.png also >seems to not be attributed to Hadoop and is unreferenced in code. Also a >candidate for deletion? > >* Copyright year exists in some files in the license header (and >shouldn't/doesn't need to, afaik) > >** ./slider-agent/src/test/python/python-wrap >** ./app-packages/storm/package/files/storm-slider > >* DEPENDENCIES is missing from top-level pom.xml RAT plugin exclusions >(causes `mvn verify -Prat -DskipTests` to fail on source release). > >Jon Maron wrote: >> Hello, >> This is a call for a vote on Apache Slider 0.81.0-incubating release. >> >> This is a source release. >> >> The list of all issues fixed: http://s.apache.org/ZnA >> >> Staged artifacts: >>https://repository.apache.org/content/repositories/orgapacheslider-1007/ >> Source zip: >>https://repository.apache.org/content/repositories/orgapacheslider-1007/o >>rg/apache/slider/slider/0.81.0-incubating/slider-0.81.0-incubating-source >>-release.zip >> Source tar.gz: >>https://repository.apache.org/content/repositories/orgapacheslider-1007/o >>rg/apache/slider/slider/0.81.0-incubating/slider-0.81.0-incubating-source >>-release.tar.gz >> >> Git source: >> >>https://git-wip-us.apache.org/repos/asf?p=incubator-slider.git;a=commit;h >>=38decaa05de8d962053e47040bab910cdb00f04d >> SHA1: 38decaa05de8d962053e47040bab910cdb00f04d >> Tag: 0.81.0-incubating >> >> PGP key: >> http://pgp.mit.edu:11371/pks/lookup?op=vindex&[email protected] >> >> Build/test instructions at: >> http://slider.incubator.apache.org/developing/building.html >> >> >> Vote will be open for 72 hours >> >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove (and reason why) >> >> >
