[ 
https://issues.apache.org/jira/browse/SLIDER-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984356#comment-14984356
 ] 

Steve Loughran commented on SLIDER-955:
---------------------------------------

I don't think that'll work, as its just a bool. But you have pointed me at the 
area which includes {{ResourceCalculator.normalize()}}, which looks like it is 
exactly what we want. 

We'll need to create a normalized resource template for cancel requests, and 
use that as the basis for new allocation requests; something like
# include minimum resource values in app state construction
# build this with a modified {{AppState.buildResourceRequirements(}}
# put into {{RoleStatus}} at setup/modified resources.json events
# copy for new resource/cancel requests

> fail to track the outstandingRequest when submit an application that 
> yarn.memory is not a multiple of minimum-allocation-mb
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLIDER-955
>                 URL: https://issues.apache.org/jira/browse/SLIDER-955
>             Project: Slider
>          Issue Type: Improvement
>          Components: appmaster
>    Affects Versions: Slider 0.80
>            Reporter: kyungwan nam
>
> "yarn.scheduler.minimum-allocation-mb” is set to 256 in my cluster.
> I submit an application that “yarn.memory” is set to 7169 (not a multiple of 
> 256)
> the resource of allocated container will be 7424(256*29) memory because the 
> resource requirement is normalized to a multiple of 
> "yarn.scheduler.minimum-allocation-mb” by RM.
> the resource requirement of outstandingRequest that is tracked by Slider AM 
> does not match the resource of the allocated container.
> therefore, Slider AM can’t clean up the outstandingRequest and requests in 
> AMRMClient.
> I think it should fix as following 1 or 2
> 1. an application should be able to submit only if “yarn.memory” is a 
> multiple of "yarn.scheduler.minimum-allocation-mb”
> 2. the resource requirement of outstandingRequest is normalized to a multiple 
> of "yarn.scheduler.minimum-allocation-mb”



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to