[ 
https://issues.apache.org/jira/browse/SLIDER-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gour Saha updated SLIDER-1166:
------------------------------
    Attachment: SLIDER-1166.2.patch

When SliderClient is used as a service - I tested that every cluster DELETE 
(stop) operation was creating and holding on to the ZK session. Over a long 
period of time, if there are significant amounts of CREATE and subsequent 
DELETE operations, the ZK connections held by this service would spike to max 
out all available ZK sessions.

The .2.patch implements a cache for the ZK sessions. It is a simple one with ZK 
quorum as keys. 

I tested that with the .2 patch only 1 additional ZK session is created for a 
quorum. I executed 100s of CREATE and subsequent DELETE operations and the 
count would not go up any further.


> Close zk client after use
> -------------------------
>
>                 Key: SLIDER-1166
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1166
>             Project: Slider
>          Issue Type: Bug
>          Components: client
>    Affects Versions: Slider 0.91
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>            Priority: Critical
>             Fix For: Slider 1.0.0
>
>         Attachments: SLIDER-1166.1.patch, SLIDER-1166.2.patch
>
>
> We aren't closing the zookeeper client, leaving it to expire and keep the 
> session open much longer than is necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to