[
https://issues.apache.org/jira/browse/SLIDER-1237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133709#comment-16133709
]
Gour Saha commented on SLIDER-1237:
-----------------------------------
Few comments -
Instead of calling e.toString() should we just pass e like an object?
SecurityUtils.java
throw new RuntimeException("Error creating certificate password file", e);
LOG.error("Error reading password from existing file", e);
CertificateManager.java
LOG.error("Got interrupted running command " + command + ":", e); // I am not
too fond of the +s here either, but the exception stack gets pretty printed to
a new line I think
LOG.error("Got IOException running command " + command + ":", e);
LOG.error("Error writing crt req file", e1);
LOG.error("Error reading signed agent certificate", e);
> Remove usages of printStackTrace
> --------------------------------
>
> Key: SLIDER-1237
> URL: https://issues.apache.org/jira/browse/SLIDER-1237
> Project: Slider
> Issue Type: Bug
> Affects Versions: Slider 0.92
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Priority: Minor
> Fix For: Slider 1.0.0
>
> Attachments: SLIDER-1237.1.patch
>
>
> We should clean up usages of printStackTrace in favor of better log messages.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
