Hi Mike, Mike Müller schrieb: > Hi Felix > >>> I'm a little bit stuck: I tried to use the newest >>> org.apache.sling.launchpad.base.jar to test SLING-922. >>> I took the org.apache.sling.launchpad.app-6-SNAPSHOT.jar and >>> replaced the org.apache.sling.launchpad.base.jar there with >>> the org.apache.sling.launchpad.base-2.0.5-SNAPSHOT.jar and >>> renamed it also to org.apache.sling.launchpad.base.jar because >>> Main depends on exactly this name of the jar (through >>> SharedConstants.DEFAULT_SLING_LAUNCHER_JAR). I created the >>> 2.0.5-SNAPSHOT.jar with mvn clean install and copied it from >>> sling/launchpad/base/target into the jar. >>> First thing I noticed is that the new jar is 100k less big than >>> the older one. >> The reason for this is, that we do not include the OSGi compendium >> library in the base jar any more (SLING-1094) >> >>> Nevertheless I tried to start Sling, but had no luck. >>> So maybe my question is a little bit silly: What is the right >>> and eaysiest way to that? >> That is not expected. What exactly is the problem ? What happens ? Any >> log messages to share ? > > The problem I found is related to the problem described in SLING-1113 [1]. > The method extractFileName uses File.separatorChar to extract the file name > without the path. But if the file comes from a jar on windows systems > File.separatorChar is "\" but the file name from a char is separated with > a "/". So the jars could not be extracted and Sling could not be started. > Maybe BootstrapInstaller.extractFileName has to check for "/" and the > File.separatorChar if it is not equal to "/" to make sure the code is > running on every platform (even if it's questionable if windows should > be supported ;-)). > > [1] https://issues.apache.org/jira/browse/SLING-1113
I see. Did you see my proposed modified patch ? (Well, I just attached it ;-) ) Regards Felix > > best regards > mike
