On Sat, Sep 19, 2009 at 09:49, Ian Boston <[email protected]> wrote: > I think this might break some behavior, as there is no way for the non > existent resource to know if an extension is a serialization extension or > the real extension of the file in the jcr, at the moment, code that uses non > existent resource assumes that the extension is not determined, and so would > need changing to be compatible with this change.
But I would say that code that depends on all the request path infos (selectors, extensions, suffix) to be "null" should be very rare and I think this is an acceptable change, especially if this code misses the quite important check if the resource is actually existing or not. The (sling) resource is clearly a NonExistingResource (easy to check) and you still have the full request path to do your own path mangling. This also means that the servlet resolution process is not affected in general, as the resource type will always be of sling/nonexisting, hence only here a different script, eg. for the swf extension, might be called - which is unlikely to be present in existing code as it would never be called with the current way. Scripts/servlets for this special resource type might be changed, but this is what this patch is all about - make them simpler and more capable. Regards, Alex -- Alexander Klimetschek [email protected]
