Hi,

Ian Boston schrieb:
> Hi,
> I notice that ResourceProvidersEntries are sorted by the prefix that
> they use. (there is a TreeMap in ResourceProviderEntries for entries)
> I also notice that if they are not ordered in that way lots of things
> start to break. This appears a bit fragile. I assume it relies on GET
> and POST appearing in a set order.
> 
> Is the sort ordering correct ?

I assume you mean the TreeSet in the
ResourceProviderEntry.addResourceProvider method ? I could not find
another location matching your description.

> Was this intentional or fortunate ?

But yes, it is intended that the ResourceProviderEntry elements in the
entries field is sorted.

To be honest ... I fail to remember why the ordering was important, I
just know it was (and still seems to be) important for correct operation.

Carsten and I have once been discussing off-line that it might be
tempting to check whether refactoring this structure into a Map of Maps
of Maps of Entries would help performance wise ... but we never came
around to testing it or to more investigation.

Regards
Felix

Reply via email to