Hi Justin,

On Thu, Nov 12, 2009 at 11:48 PM, Justin Edelson
<jus...@justinedelson.com> wrote:
>...I'd like to suggest enhancing
> the maven-sling-plugin with a new goal which will handle much of the
> configuration being done now via the maven-dependency-plugin....

I like the idea.

Trying to reformulate, if I understand correctly, with your
enhancement creating a runnable Sling jar containing custom bundles
consists of

1) Selecting a base sling artifact that provides a set of default bundles
2) Listing a number of additional bundles to include, each with their
own start level

As demonstrated in your http://gist.github.com/233240 example.

Two minor things on that example:

1)
 <executions>
      <execution>
        <goals><goal>prepare</goal></goals> <!-- granted, this is a
questionable goal name -->
      </execution>
   </executions>

How about "create-app" as the goal name?

2)
   <configuration>
     <includeDefaultBundles>true</includeDefaultBundles> <!-- if true,
contents of org.apache.sling.launchpad.bundles get unpacked -->
     <defaultBundlesVersion>6-SNAPSHOT</defaultBundlesVersion> <!--
support LATEST, RELEASE here ? -->

Wouldn't it be clearer to use

<default-bundles>
  ...reference to a Maven artifact, as usual...
</default-bundles>

Thanks for your proposal!
-Bertrand

Reply via email to