[
https://issues.apache.org/jira/browse/SLING-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784107#action_12784107
]
Felix Meschberger commented on SLING-1179:
------------------------------------------
Patch basically looks good.
But: I always was a bit at unease by a slight asymmetry between the standalone
and the web app launcher: The standalone launcher does not contain the OSGi
HttpService implementation in the launchpad/base module but only adds this in
the launchpad/app module. The web app launcher on the other hand contains
everything required to provide a fully functional OSGi Http Service already in
the launchpad/base module.
Now, I wonder whether we could create more symmetry here:
* The servlet API which is not required at all should probably not be added
anymore:
* The web app launcher should use the container provided library
* The standalone launcher will leverage the API provided by the
OSGi Http Service implementation
--> should we remove the Servlet API from the launcher JAR ?
* Now that the bridge and the full HttpService implementation are both
bundles, we should probably
make the addition to the resulting build symmetric.
--> I propose to move the bridge bundle addition off to the
launchpad/webapp project (similar to the current launchpad/app)
WDYT ?
> Convert Launchpad Webapp to use Felix HttpService instead of Equinox
> --------------------------------------------------------------------
>
> Key: SLING-1179
> URL: https://issues.apache.org/jira/browse/SLING-1179
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
> Affects Versions: Launchpad Base 2.1.0
> Reporter: Justin Edelson
> Assignee: Felix Meschberger
> Fix For: Launchpad Base 2.2.0
>
> Attachments: consolidated_felix_fixes_for_SLING-1179.patch,
> SLING-1179-post-felix-release.patch, SLING-1179.patch
>
>
> I almost have this working and will submit a patch soon, but I wanted to go
> ahead and create a JIRA issue to link to some bugs in the Felix HttpService
> which will block the implementation of this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
