Change from maven-bundle-plugin 1.4.3 to 2.0.1 causes launchpad.base.jar to
have too much stuff in it
-----------------------------------------------------------------------------------------------------
Key: SLING-1254
URL: https://issues.apache.org/jira/browse/SLING-1254
Project: Sling
Issue Type: Bug
Components: Launchpad
Reporter: Justin Edelson
After r892734, the launchpad base jar has more content in it than it should
(850 files instead 269 files). Most significantly, the contents of
org.apache.sling.launchpad.base.shared are included which causes this exception:
> org.osgi.framework.BundleException: sling.home property is missing, cannot
> start
This appears to be because of a change in behavior in the maven-bundle-plugin
between 1.4.3 and 2.0.1.
The fix is to replace the last line in the Private-Package instruction with
org.apache.sling.launchpad.base.* and add an Export-Package instruction.
HOWEVER, the manifest that results from this is slightly different than the one
produced prior to r892734. Specifically, it no longer has a Private-Package
header. I'm not really sure why this is, but it doesn't seem to be a problem.
diff --git a/launchpad/base/pom.xml b/launchpad/base/pom.xml
index 2c5364d..8180955 100644
--- a/launchpad/base/pom.xml
+++ b/launchpad/base/pom.xml
@@ -69,8 +69,9 @@
!org.apache.sling.launchpad.app.*,
!org.apache.sling.launchpad.base.shared.*,
!org.apache.sling.launchpad.webapp.*,
- *
+ org.apache.sling.launchpad.base.*
</Private-Package>
+ <Export-Package>!*</Export-Package>
<Import-Package>!*</Import-Package>
<DynamicImport-Package>*</DynamicImport-Package>
<Embed-Dependency>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
