[
https://issues.apache.org/jira/browse/SLING-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828032#action_12828032
]
Thomas Mueller commented on SLING-1283:
---------------------------------------
Another reason why the session pool is problematic:
There is a memory leak. The session pool prevents unclosed sessions from being
garbage collected.
The application may run out of memory if the user forgets to close sessions.
The session pool keeps a hard reference to each open session (in an
IdentityHashMap).
P.S. A similar leak existed in Jackrabbit Core, but is now fixed: JCR-1216
> Remove Session Pool Support
> ---------------------------
>
> Key: SLING-1283
> URL: https://issues.apache.org/jira/browse/SLING-1283
> Project: Sling
> Issue Type: Task
> Components: JCR
> Affects Versions: JCR Base 2.0.4
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: JCR Base 2.1.0
>
> Attachments: SLING-1283.patch
>
>
> The Session Pool Support code in the jcr/base bundle has a few issues:
> * Only works with SimpleCredentials authentication
> * Wrong level of abstraction: such optimizations are the task of the
> repository implementation and not of the user
> * Cleanup of the session for reuse is brittle and timeconsuming (due to a
> JCR search to ensure unlocking transient locks)
> * Little to no gain in performance (in fact performance is even lower than
> using plain Jackrabbit Sessions.
> In addition, I suspect session pooling to be responsible for various strange
> integration test failures (see also SLING-1272).
> Therefore Session Pool support should be removed.
> See also the dev list discussion at
> http://markmail.org/thread/wiiqs2ym75mpfxcd
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
