On 2/12/10 8:22 AM, Ian Boston wrote: > > On 12 Feb 2010, at 13:06, Carsten Ziegeler wrote: > >> Ian Boston wrote: >>> On 12 Feb 2010, at 12:03, Carsten Ziegeler wrote: >>> >>>>> 908956 SLING-1366 : Use dynamic proxy to handle session#impersonate call. >>>> I think this one should go into the release as this fixes a broken >>>> implementation. There is currently a line in there which excludes the >>>> pre jsr 283 interfaces. So we should remove this line. >>> >>> Done this, you might want to have a quick look at the patch [1] that makes >>> this change, however, the Ace integration tests are failing, same as trunk >>> head at 908994. >>> >> Looks good to me; let's give it a go and then see what we need to fix >> for the tests. > > I am getting failures on > Failed tests: > > testModifyAceForUser(org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest) > > testModifyAceForGroup(org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest) > > testRemoveAce(org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest) > > testRemoveAces(org.apache.sling.launchpad.webapp.integrationtest.accessManager.RemoveAcesTest) > > > eg > testModifyAceForUser(org.apache.sling.launchpad.webapp.integrationtest.accessManager.ModifyAceTest) > Time elapsed: 0.151 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<200> but was:<500> > > I cant find any matching exception in the error log at the moment.
This sounds to me like you still have the jcr 2 bundle and a newer sling.jcr.api bundle. But looking at the patch set, this isn't the case so I'm confused. If these are the only test failures, you might as well commit your changes as these same tests are failing now. I can take a closer look in 30-45 mins. If it's the same problem I saw yesterday (with the wrong getAccessManager() method being called), you won't see an exception in the logs because it is logged at the debug level (by AccessControlUtil IIRC). Justin > > Ian > > >> >> Carsten >> >>> >>> 1. http://codereview.appspot.com/206082/diff2/1:28/1005 >>> >>>> Regards >>>> Carsten >>>> >>>> -- >>>> Carsten Ziegeler >>>> [email protected] >>> >>> >> >> >> -- >> Carsten Ziegeler >> [email protected] >
