Hi,
On 24.03.2010 12:04, Carsten Ziegeler wrote:
> I moved the service, but how do we proceed?
>
> We can:
> a) copy the request and response util classes from engine to api so
> people have everything in a single place
> b) create the utilities bundle as Felix suggested
> c) leave everything as it is
>
> I'm personally in favour of a) :)
I came to dislike mixing API (interfaces, exceptions) with
implementations (classes, utilities). Thus my preference would be b. But
(a) would be ok for me, too.
We should also discuss about the rest of the o.a.s.engine contents:
* EngineConstants
sling.home/sling.home.url - maybe move to SlingConstants
and have them provided by the SlingSettingsService ?
SLING_CURRENT_SERVLET_NAME - maybe make this an official
request attribute while handling a sling request (and
move the constant to SlingConstants) ?
or add this to the SlingHttpServletRequest ?
SLING_SERLVET_NAME - This is Sling Engine specific for
initializing servlets with configuraiton.
Shouldn't we move initialization of Servlets to the
Servlet Resolver which also registers them with the
ResourceResolver ?
* RequestLog - this is probably Engine specific and
should stay here. But: do we need it really ??
Regards
Felix
