Justin Edelson wrote > Argh. I see the problem now. I had setup code to create the ws2 > workspace in the Listener test, but not in the Resolver test. Fixed in > r933956. Cool, thanks!
> Makes sense. This code is not optimized, but I wanted to get something > committed. Yes, sure - no problem - that's the way open source works :) I was just in the middle of performance tests and got it by the changes, but that's more my fault :) > Ideally, there's a character which is: > 1) illegal in a JCR node name > 2) legal in a URL path > > I just don't know off the top of my head what that would be. Yepp - I don't have a clue either. > > Barring this, I agree that requiring an absolute path is the right > solution. If you need to pass a relative path to getResource(), you > could always specify a search path entry like "ws2:/" in the > JcrResourceResolverFactoryImpl config. Or use the two-argument form of > getResource(). Ok, so I guess we can go with the current solution. >> In addition, I'm wondering if we could make this feature completly >> optional (maybe by a resource resolver wrapper etc.)? (But I think this >> is something we can look into later on) > I think this should just be a config option on > JcrResourceResolverFactoryImpl which bypasses the new code blocks > entirely. The only thing we need to watch out for here is that if you > enable non-default workspace observation, non-default workspace > resolution must be enabled, but this is reasonably simple to deal with. Ok, right - I think the configuration part is no problem. I'll try to add a switch to the code and see how it turns out Regards Carsten > > Justin > >> >> Regards >> Carsten >> >> justin wrote >>> Author: justin >>> Date: Tue Apr 13 19:13:31 2010 >>> New Revision: 933747 >>> >>> URL: http://svn.apache.org/viewvc?rev=933747&view=rev >>> Log: >>> SLING-1447 - committing first pass at workspace names in resource paths >>> >>> Added: >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/WorkspaceDecoratedResource.java >>> >>> sling/trunk/bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceListenerTest.java >>> >>> sling/trunk/bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/SynchronousJcrResourceListener.java >>> Modified: >>> sling/trunk/bundles/jcr/resource/pom.xml >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/JcrResourceConstants.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceResolver.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceResolverFactoryImpl.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/ResourceDecoratorTracker.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/ResourceIteratorDecorator.java >>> >>> sling/trunk/bundles/jcr/resource/src/main/java/org/apache/sling/jcr/resource/internal/helper/ResourceProviderEntry.java >>> >>> sling/trunk/bundles/jcr/resource/src/test/java/org/apache/sling/jcr/resource/internal/JcrResourceResolverTest.java >> > > -- Carsten Ziegeler [email protected]
