On Thu, Jun 3, 2010 at 12:47 PM, Ian Boston <[email protected]> wrote: > > On 3 Jun 2010, at 09:04, [email protected] wrote: > >> Modified: >> sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java >> URL: >> http://svn.apache.org/viewvc/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java?rev=950907&r1=950906&r2=950907&view=diff >> ============================================================================== >> --- >> sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java >> (original) >> +++ >> sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java >> Thu Jun 3 08:04:42 2010 >> @@ -57,7 +57,6 @@ public class TestAll extends TestCase { >> "**/launchpad/webapp/integrationtest/**/*Test"); >> String testRegex = convertToRegex(testPattern); >> Pattern pattern = Pattern.compile(testRegex); >> - LOGGER.info("Using Pattern " + testRegex); >> for (URL u : urls) { >> try { >> matchingClasses.addAll(scanFile(new File(u.toURI()), >> pattern)); > > > Might be an idea to leave this in as, at the moment we are parsing the maven > DirectorySet and converting it to a regex. > I think the conversion is correct, but I cant be sure for everything that > someone might decided to enter....
Sure - I didn't remove the log statement, just moved it a few lines later in the method, so as to include the number of test classes found, is that ok with you? > (also.... every time I do a regex... it does my head in :)) of course ;-) -Bertrand
