On 24 Jun 2010, at 13:10, Justin Edelson wrote: > > > On Jun 24, 2010, at 5:34 AM, Ian Boston <[email protected]> wrote: > >> Could we make the :skipCheckin :checkin? > > How about :performCheckin and have the default value set via ConfigAdmin?
that would be better, from a sakai point of view we can configure the defaults (we could also have simply patched the code base), but form a wider Sling community point of view others may want the default to be "don't perform checking." >> >> We are going to have to find all our posts in lots of javascript and add the >> param, or ask ops to buy lots more disk. We use the jcr to store portal >> state, which we really do not want to be versioned. > > As I said before, I don't see that you will need to change anything. > Versionable nodes must be checked out before modifying them; if you are > modifying versionable nodes today, then you must be doing the checkout before > the post. Already checked out nodes are NOT impacted by this patch. Well, IIRC (evidenced by the fact we have most nodes versionable and we don't have to check then out at present) versionable nodes are checked out by default, so you can modify them, however thats not the problem. If you use JCR to store state and configuration information and you expect to make lots of modifications that you don't want to store versions of, then this change will, by default, make you store versions of every modification, even though you didn't want to..... I guess its a philosophy thing. Should the client opt in or opt out of checking in every version? Upto now, all Sling clients have explicitly opted in. I am just arguing, to keep the change backwards compatible, that should remain the case. WDYT? Ian > > Justin >> >> Ian >> >> Sent from my iPhone >> >> On 24 Jun 2010, at 03:23, "Justin Edelson (JIRA)" <[email protected]> wrote: >> >>> >>> [ >>> https://issues.apache.org/jira/browse/SLING-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882011#action_12882011 >>> ] >>> >>> Justin Edelson commented on SLING-1573: >>> --------------------------------------- >>> >>> updated patch at http://codereview.appspot.com/1732045 >>> >>> As discussed in http://sling.markmail.org/thread/uqi7qfw4j3hvedzx, this >>> patch automatically check out nodes needing to be checked out in order to >>> be modified and check in any nodes which were checked out as part of #1, >>> unless :skipCheckin is specified as a parameter. Nodes which were already >>> checked out will remain checked out. >>> >>> By default, new versionable nodes will be checked in. Likewise, existing >>> non-versionable nodes which are made versionable through the addition of >>> the mix:versionable mixin will also be checked in. These defaults can be >>> overridden via the :skipCheckin parameter. >>> >>> In addition, there are new checkin and checkout operations. >>> >>> Technically, this is not backwards-compatible in that today it is >>> impossible to modify a checked in node whereas after this patch it will be, >>> but I personally think this is a good thing :) >>> >>>> Support for Versionable nodes in post servlet >>>> --------------------------------------------- >>>> >>>> Key: SLING-1573 >>>> URL: https://issues.apache.org/jira/browse/SLING-1573 >>>> Project: Sling >>>> Issue Type: Improvement >>>> Components: Servlets >>>> Reporter: Justin Edelson >>>> Fix For: Servlets Post 2.0.6 >>>> >>>> >>>> SLING-608 mentions versions (and SLING-848 talks about accessing >>>> versionable nodes), but we don't have an issue for creating and modifying >>>> versionable nodes as well as performing basic checkin and checkout >>>> operations. >>> >>> -- >>> This message is automatically generated by JIRA. >>> - >>> You can reply to this email to add a comment to the issue online. >>>
