Hi Federico,

I had a closer look at your code from
http://davidgsoc2010.googlecode.com/svn/trunk revision 22, here are my
comments.

The main thing is that I haven't been able to test the CRUD functions
completely, could you provide an instructions page (similar to my
testing steps below, just basic information about how to do the CRUD
cycle) or screencast with the steps that you use to create, retrieve,
update and delete an entry? Would be good to have that tomorrow if you
have time to work on it.

You can write that on the public Sling wiki at
https://cwiki.apache.org/confluence/display/SLING/Index, or on your
Google code wiki, whatever's more convenient.

I'll then try again with your suggested scenario.

A few comments upfront:

1. The ckeditor javascript and other files should be provided in a
separate bundle, using Sling-Bundle-Resources as done by the
contrib/extensions/dojo bundle. This will make your bundle simpler and
dedicated to your application, and will avoid "polluting" the
repository with those source files, as they will be served from inside
the bundle.

2. Same for the iText stuff, should be a separate bundle.

3. We don't usually have utility scripts like your start.bat in our
code repository

Nothing urgent, you can fix those things after we get the CRUD part reviewed.

Here's what I tried so far:

0. Start sling using the launchpad/builder standalone jar, current
trunk, after deleting the "sling" working folder to start clean.

1. Apply enclosed patches for pom.xml and david.json - the "name"
property in the latter meant that the node was created at
"/content/Starting Point", there was no node at /content/david which
might explain your "start at /content/david does not work" problem.

2. Build and install bundle

2. Start at http://localhost:8888/content/david.html
-> rendered by HtmlRendererServlet - I would expect a CMS home page
with explanations here

3. Try http://localhost:8888/content/david.list.html
-> Menu page to create, list and search entries looks good. Should be
the default rendering of david.html IMO.

4. Use menu item to get to /content/david.new to create an entry
-> Editing page looks nice
-> Way too many menu options for my taste in the editor
-> Submit button doesn't seem to save, I get a JS dialog saying
[object XMLHttpRequest]
-> I wasn't able to save an entry

-Bertrand

Patches:

Index: pom.xml
===================================================================
--- pom.xml     (revision 22)
+++ pom.xml     (working copy)
@@ -67,6 +67,11 @@
                         </Sling-Initial-Content>

<Export-Package>sling.gsoc.david.servlet</Export-Package>

<Private-Package>sling.gsoc.david.servlet.*</Private-Package>
+                        <Import-Package>
+                            !org.bouncycastle.*,
+                            !javax.crypto.*,
+                            *
+                        </Import-Package>
                         <Embed-Dependency>itextpdf</Embed-Dependency>
                     </instructions>
                 </configuration>


--- src/main/resources/initial-content/content/david.json       (revision 22)
+++ src/main/resources/initial-content/content/david.json       (working copy)
@@ -1,5 +1,5 @@
 {
-       "name": "Starting point",
+       "name": "david",
        "primaryNodeType": "nt:unstructured",
        "sling:resourceType": "david",
        "jcr:primaryType": "nt:unstructured"

Reply via email to