On Tue, Jul 13, 2010 at 09:47:00AM -0400, Justin Edelson wrote:
> On 7/12/10 9:18 AM, D. Stuart Freeman wrote:
> > On Sat, Jul 10, 2010 at 09:38:08PM -0400, Justin Edelson wrote:
> >> On 7/9/10 3:17 PM, D. Stuart Freeman wrote:
> >>> On Fri, Jul 09, 2010 at 10:55:14AM -0400, Justin Edelson wrote:
> >>>> I think the simplest thing would be to add the emma jar to the
> >>>> classpath and then add the necessary package(s) to the packages
> >>>> exported by the system bundle (i.e. via sling.system.packages). You
> >>>> can do this by adding emma as a dependency to the
> >>>> maven-launchpad-plugin and create a file called
> >>>> src/test/config/sling.properties with this line in it:
> >>>>
> >>>> sling.system.packages.simple=com.vladium.emma.rt
> >>>>
> >>>
> >>> That makes sense, but I can't seem to figure out where to put the
> >>> dependency so that it actually works.
> >>
> >> Take a look at http://codereview.appspot.com/1807041, specifically
> >> http://codereview.appspot.com/1807041/patch/1/5
> >>
> >> Here I'm putting the emma stuff in a profile, so you'd run it like
> >>
> >> mvn -P emma clean verify
> >>
> >> I verified that when not using the instrumented bundles, I don't need
> >> emma on the classpath, so I'm not sure how to explain what you were
> >> seeing where the uninstrumented bundles still needed emma.
> >>
> > 
> > I'm trying to have the launchpad start with my alternative bundle list,
> > but have the build output a launchpad jar with the uninstrumented
> > bundles.  This might not be ideal, and I may have some configuration
> > issue that's getting instrumented bundles into my launchpad jar.
> This *is* ideal... at least with the way integration tests are run in
> Sling, there shouldn't be a need to package the emma bundles into a
> launchpad jar. To do this, you need to move the emma bundle list
> configuration to specific executions within the plugin block:
> 
> http://codereview.appspot.com/1829041/patch/1/5
> 

That makes sense but doesn't fix my problem.  I think what's happening is
that my uninstrumented bundles go into the launchpad, but the launchpad
itself is instrumented, perhaps because of the emma outputDirectory issue
you mentioned earlier.

> Justin

-- 
D. Stuart Freeman
Georgia Institute of Technology

Attachment: signature.asc
Description: Digital signature

Reply via email to