Hi, On 21.07.2010 10:33, Bertrand Delacretaz wrote: > On Wed, Jul 21, 2010 at 10:17 AM, Carsten Ziegeler <[email protected]> > wrote: >> ...Yes, I know - but...if we base just on the http servlet request/response >> we don't need a builder at all. Everything can be handled internally.... > > We could also provide convenience builders in a separate bundle: keep > the changes to the engine bundle minimal, and create a > commons/requests bundle for the builders. I suspect we need to > experiment a bit with those, and that's much easier if they're in > their own bundle. > > Currently the SlingServlet puts just one constraint on the request: it > has to provide a ResourceResolver in an attribute. > > In my current SLING-1603 patch the API is: > > public interface SlingServlet { > void processRequest(HttpServletRequest request, > HttpServletResponse resource, ResourceResolver resourceResolver) > throws IOException; > } > > So it looks like we could just add this to the engine, WDYT?
I am not a fan of quick-shot solutions which have an influence on exported API. Therefore I would like to do it right from the start (or not at all). If we come up with something half-backed, we might end up in a backwards-compatibility-support-mess. What we should probably do, is to release the engine for later inclusion with Sling 6 before we start "experimenting" or working on this extension. Regards Felix
