[
https://issues.apache.org/jira/browse/SLING-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893975#action_12893975
]
Felix Meschberger commented on SLING-1193:
------------------------------------------
Thanks for your follow-up fixes.
I have fixed the ResourceUtil problem in Rev. 980686 by reintroducing the old
ResourceUtil method implementations and not relying on the Resource API. As a
consequence I have implemented some of the new Resource methods in the
AbstractResource class calling into ResourceUtil to prevent duplicate code
(except for getName, getChild and listChildren where the implementation is
reasonably simple as to warrant duplicate code; I nevertheless added some
comment to the ResourceUtil implementation).
> Extend Resource interface and provide AbstractResource base class
> -----------------------------------------------------------------
>
> Key: SLING-1193
> URL: https://issues.apache.org/jira/browse/SLING-1193
> Project: Sling
> Issue Type: New Feature
> Components: API, Engine, JCR, Scripting, Servlets
> Affects Versions: Servlets Resolver 2.0.8, Scripting Core 2.0.10, JCR
> Resource 2.0.6, Engine 2.0.6, API 2.0.8
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Servlets Resolver 2.0.10, Scripting Core 2.0.12, JCR
> Resource 2.0.8, Engine 2.1.0, API 2.1.0
>
>
> Currently the Resource interface has only bare bones API to access its own
> local attributes, like getPath() or getResourceType().
> Accessing the resource in the context of its parent or its children is not
> currently possible and doing so requires getting the resource resolver out of
> the resource and asking the resource resolver.
> For convenience, we should add the following methods:
> getParent() -- returns the parent resource (same as
> ResourceUtil.getParent(this))
> getName() -- returns the name of the resource (same as
> ResourceUtil.getName(this))
> listChildren() -- same as getResourceResolver().listChildren(this)
> getChild(String) -- same as getResourceResolver().getResource(this, path)
> isResourceType(String) -- same as ResourceUtil.isA(this, String)
> The new AbstractResource class will implement these methods as indicated.
> Implementors of the Resource interface are then advised to actually extend
> from the AbstractResource interface, which in the future will provide default
> implementations of any methods added to the Resource interface, if it makes
> sense.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.