Hi, On 02.09.2010 14:07, Carsten Ziegeler wrote: > Justin Edelson wrote >> Servlets >> * SLING-1069 - Servlets registered with default resource type responds >> to all extensions >> * SLING-892 - Allow servlets to be regsitered with extensions for all >> request methods > While these two would be nice to have, I think they should not block > Sling 6; there is no patch for SLING-892 and we didn't come to a > conclusion for SLING-1069. If we can solve this in the next days, I'm > fine - if not, let's move them to the next release.
I have been looking at these issues again (see updates). For 892 I had a patch lying in my workspace for quite some time now ... never came around attaching it. Anyway, this small patch would allow non-GET servlets to be considered with selector and extension. As for 1069 the issue is, thar probably a full permutation of the declared selectors, extensions, and method names should be used for registering. I have attached an alternate patch to Vidar's patch which looks more complete. As such this would make 1069 dependent on 892 because there's no value registering non-GET servlets for selectors and extensions... Maybe this was the reason to not use full permutations for registration at that time. So, if there is no opposition, I would like to apply these patches and try to come up with some tests for the 2.1.0 release of the resolver. WDYT ? Regards Felix > > Carsten
