I looked at the source references in both mina and karaf. In both cases, I believe they're using these classes inappropriately and unnecessarily. See DIRMINA-794 and KARAF-198, both with relatively simply patches.
However, what I didn't see is any dependency from mina on the spi package. I put a comment in SLING-1739 asking for clarification on this. I'll revise my -1 to say -1 to export spi -0.5 to export helpers Justin On 9/9/10 4:22 PM, Felix Meschberger wrote: > Hi, > > I am tempted to agree with respect to SPI, of course. > > With respect to helpers, I am not really sure. Looking at the mina.core > code, they have some class in there which uses the BasicMDCAdapter class > from the helpers package. > > As for exposing a Sling-repackage: I think if we consider replacing our > homegrown SLF4J SPI implementation with an existing implementation, we > should not do this. > > Since you actually vetoed the commit, I have reverted it (with respect > to the export) for now. > > Regards > Felix > > > On 09.09.2010 20:16, Justin Edelson (JIRA) wrote: >> >> [ >> https://issues.apache.org/jira/browse/SLING-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907709#action_12907709 >> ] >> >> Justin Edelson commented on SLING-1739: >> --------------------------------------- >> >> -1 on exporting spi and helpers. These packages are for implementers of >> SLF4J, not API consumers. The only exports from commons log should be >> logging APIs. If we decide to expose an SPI, that should be done in a Sling >> package and then mapped internally to the bundle to the SPI of whatever >> implementation we happen to be using at the time. >> >>> Update Commons Log exported SLF4J version >>> ----------------------------------------- >>> >>> Key: SLING-1739 >>> URL: https://issues.apache.org/jira/browse/SLING-1739 >>> Project: Sling >>> Issue Type: Improvement >>> Components: Commons >>> Affects Versions: Commons Log 2.0.6 >>> Reporter: Jason Rose >>> Assignee: Felix Meschberger >>> Priority: Minor >>> Fix For: Commons Log 2.0.8 >>> >>> Attachments: commons-log.patch >>> >>> >>> Commons Log is currently exporting version 1.5.2 of SLF4j. This is a very >>> old version of the library. I'm currently using Commons Logging as a >>> replacement for PAX Logging because of classloading issues with PAX in >>> JBoss, and I needed to make a couple changes to facilitate that. >>> Updating the dependency and exported versions of SLF4j fixes most of the >>> issues I have with trying to exclusively use Commons Log. In addition to >>> updating the version, I've moved the spi and helpers packages into the >>> exported packages instead of private packages. This makes it mirror PAX >>> more closely and handles all the logging requirements of 3rd party bundles >>> in my application. >>
