Hi Felix, On Tue, Dec 14, 2010 at 7:01 AM, Felix Meschberger <[email protected]>wrote:
> Hi Justin, > > Agreed. Though I did not yet take a deep look into your provided patch > (should do that RSN ... ;-) ). > > Incidentally, I am also working on the Launchpad Base module (see > SLING-1888). > I couldn't tell if you were actively working on this. Has FindHook support been implemented somewhere in Felix or Equinox? Justin > > Regards > Felix > > Am Montag, den 13.12.2010, 23:44 -0500 schrieb Justin Edelson: > > As I alluded to in my vote email, I'd like to merge in the changes I have > in > > a branch which allows for ConfigAdmin files to be loaded from the > launchpad > > JAR/WAR. I haven't really done anything about this since the summer, but > I'm > > pretty happy with the solution I came up with (see > > http://codereview.appspot.com/1997042/). > > > > This is, strictly speaking, not backwards compatible for "embedders" of > > launchpad, but the only embedder we have is the maven-launchpad-plugin. > > Hopefully, once these changes are merged and the next rev of launchpad > > released, I can spend some time documenting how launchpad can be embedded > in > > case anyone wants/needs to do that (although I think the JAR/WAR use > cases > > cover most people's needs). > > > > To be clear, for code running inside launchpad, these changes are > entirely > > backwards compatible - they only impact the code running outside > launchpad. > > Code running inside launchpad can use the new LaunchpadContentProvider > > service to get access to the launchpad archive's contents, but that's > > entirely new functionality. > > > > I'll hopefully have a chance to update the patch and apply it sometime > > mid-week, but I wanted to give a heads up because it's probably going to > be > > a pain to unmerge if someone doesn't like it :) > > > > Justin > > >
