[
https://issues.apache.org/jira/browse/SLING-9903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230665#comment-17230665
]
Bertrand Delacretaz edited comment on SLING-9903 at 11/12/20, 2:32 PM:
-----------------------------------------------------------------------
[~Henry Kuijpers], as you wrote the existing in-Sling tests, what do you think
of
[https://github.com/apache/sling-org-apache-sling-adapter-annotations/pull/2] ?
It's just testing the {{OSGI-INF/*.xml}} files for data that's generated due to
our annotations, instead of running a Sling instance. Do you think we need to
test more than that?
was (Author: bdelacretaz):
[~Henry Kuijpers] what do you think of
[https://github.com/apache/sling-org-apache-sling-adapter-annotations/pull/2] ?
It's just testing the {{OSGI-INF/*.xml}} files for data that's generated due to
our annotations, instead of running a Sling instance. Do you think we need to
test more than that?
> Validate the generated OSGi metatada instead of running a Sling instance
> ------------------------------------------------------------------------
>
> Key: SLING-9903
> URL: https://issues.apache.org/jira/browse/SLING-9903
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Adapter Annotations 2.0.0
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
>
> I took another look at the
> https://github.com/apache/sling-org-apache-sling-adapter-annotations and
> considering that the annotations act at build time only (together with the
> bnd plugin) I don't think we need to start a Sling instance to validate them.
> I'll prepare a PR that checks the XML files generated in the OSGI-INF folder,
> that should be sufficient.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
