[
https://issues.apache.org/jira/browse/SLING-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233694#comment-17233694
]
Bertrand Delacretaz commented on SLING-9901:
--------------------------------------------
Thank you very much for this! Do you have a brief explanation of why the
{{test*twice}} are needed?
I'd like to add a brief comment in those test methods as they are a bit unusual
- feel free to add that directly to the PR or here. Apart from that I'm ready
to merge the PR.
> JcrSystemUserValidatorTest contains not tests for system users
> --------------------------------------------------------------
>
> Key: SLING-9901
> URL: https://issues.apache.org/jira/browse/SLING-9901
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Reporter: Angela Schreiber
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> _org.apache.sling.jcr.resource_ comes with a {{JcrSystemUserValidator}} that
> adds validation to service-user-mapping and if enable prevents regular users
> or groups from being mapped.
> however, {{JcrSystemUserValidatorTest}} doesn't contain a single test case
> verifying if the validation is actually successful for system users (or that
> disabled system users would not be valid).
> i suspect that this is due to the fact that
> {{org.apache.sling.commons.testing.jcr.RepositoryTestBase}} creates a
> Jackrabbit repository and has never been adjusted to allow for an Oak
> repository to be used as test repository. In other words: an attempt to
> create a system user will fail.
> [~rombert], is there an alternative to the {{RepositoryTestBase}} that would
> operate on a Oak repository?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
