[ 
https://issues.apache.org/jira/browse/SLING-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239200#comment-17239200
 ] 

Ashish Chopra commented on SLING-8921:
--------------------------------------

bq. this change is backwards incompatible with Sling-testing-client-1.2.4 and 
the consumers of sling-testing-client need to adapt accordingly?
An example of such a consumer is cq-testing-clients-65. [0]

[0] https://github.com/adobe/aem-testing-clients/commits/cq-65

> requestPath must to be encoded in SlingClient#doGet()
> -----------------------------------------------------
>
>                 Key: SLING-8921
>                 URL: https://issues.apache.org/jira/browse/SLING-8921
>             Project: Sling
>          Issue Type: Bug
>          Components: Apache Sling Testing Clients
>            Reporter: Valentin Olteanu
>            Assignee: Andrei Dulvac
>            Priority: Minor
>             Fix For: Apache Sling Testing Clients 1.2.6
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> [SlingClient#doGet()|https://github.com/apache/sling-org-apache-sling-testing-clients/blob/609cb61fd2dec08657556b9adc91e889911a230e/src/main/java/org/apache/sling/testing/clients/AbstractSlingClient.java#L492]
>  requires `requestPath` to be encoded (because it's passed to multiple URI 
> constructors). 
> The contract should be uniform: all the parameters are passed decoded and the 
> method takes care to encode them properly before creating the request.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to