[ 
https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242510#comment-17242510
 ] 

Angela Schreiber commented on SLING-9692:
-----------------------------------------

[~cziegeler], [~rombert], [~dsuess], [~karlpauls], i invested a tiny bit if 
time on drafting how support for principal-based access setup (and optionally 
enforcing it) could look like in the converter.

since i am not extremely familiar with the converter it might well be that i 
missed quite some things.... one of my bigger question mark is on how this 
module is used and where/how to add configuration options (ended up with 
{{ContentPackage2FeatureModelConverterLauncher}} but that was just a wild guess 
without searching all the code).

other than that i tried to report any kind of issues spotted while working on 
the patch. some of them i had to (partially) incorporate in the patch already 
as they prevented me from performing any kind of tests with the principal-based 
ac setup....
i hope though you still get the overall intention... you will see plenty of 
FIXME comments inserted in places where i didn't complete the fix for an 
"unrelated" but blocking problem and just left a stub.

the patch also marks 2 of the existing tests as ignored as their setup seemed 
bogus to me and i didn't want to spend time on tests that IMO anyway need to be 
refactored. in addition a new test is ignored due to SLING-9953. more tests (in 
particular ITs) would for sure be needed.... just wanted to make surethe code 
is breaking all over the place ;)

> Add support for principal-based access control entries
> ------------------------------------------------------
>
>                 Key: SLING-9692
>                 URL: https://issues.apache.org/jira/browse/SLING-9692
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Robert Munteanu
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.0.24
>
>         Attachments: SLING-9692.patch
>
>
> When passed a content package that contains principal-based access control 
> entries, the converter ignores them. It should instead generate the proper 
> repoinit statements.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to