[
https://issues.apache.org/jira/browse/SLING-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Angela Schreiber updated SLING-9959:
------------------------------------
Description:
-found the following repo-init statement to create system users:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java#L109
which states:
{code}
formatter.format("create service user %s with path %s%n", systemUser.getId(),
systemUser.getPath());
{code}
now.... i might be mistaken, but if my reading of the {{SystemUserParser}} is
correct, the path defined with the {{SystemUser}} instance actually reflects
the path of the system user node itself:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/SystemUsersEntryHandler.java#L70-L75
if that was true the repo-init statements would be wrong, because the path
argument doesn't specify that path of the user node itself but rather the
intermediate path to be used.
so the statement should probably read:
{code}
formatter.format("create service user %s with path %s%n", systemUser.getId(),
systemUser.getParent().getPath());
{code}
-
was:
found the following repo-init statement to create system users:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java#L109
which states:
{code}
formatter.format("create service user %s with path %s%n", systemUser.getId(),
systemUser.getPath());
{code}
now.... i might be mistaken, but if my reading of the {{SystemUserParser}} is
correct, the path defined with the {{SystemUser}} instance actually reflects
the path of the system user node itself:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/SystemUsersEntryHandler.java#L70-L75
if that was true the repo-init statements would be wrong, because the path
argument doesn't specify that path of the user node itself but rather the
intermediate path to be used.
so the statement should probably read:
{code}
formatter.format("create service user %s with path %s%n", systemUser.getId(),
systemUser.getParent().getPath());
{code}
> SystemUser.getPath must reveal the path of the original user node
> -----------------------------------------------------------------
>
> Key: SLING-9959
> URL: https://issues.apache.org/jira/browse/SLING-9959
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
> Reporter: Angela Schreiber
> Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.24
>
>
> -found the following repo-init statement to create system users:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/acl/DefaultAclManager.java#L109
> which states:
> {code}
> formatter.format("create service user %s with path %s%n", systemUser.getId(),
> systemUser.getPath());
> {code}
> now.... i might be mistaken, but if my reading of the {{SystemUserParser}} is
> correct, the path defined with the {{SystemUser}} instance actually reflects
> the path of the system user node itself:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/handlers/SystemUsersEntryHandler.java#L70-L75
> if that was true the repo-init statements would be wrong, because the path
> argument doesn't specify that path of the user node itself but rather the
> intermediate path to be used.
> so the statement should probably read:
> {code}
> formatter.format("create service user %s with path %s%n", systemUser.getId(),
> systemUser.getParent().getPath());
> {code}
> -
--
This message was sent by Atlassian Jira
(v8.3.4#803005)