[ 
https://issues.apache.org/jira/browse/SLING-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245861#comment-17245861
 ] 

Konrad Windszus edited comment on SLING-9984 at 12/8/20, 12:25 PM:
-------------------------------------------------------------------

It seems the formatting has changed 
https://stackoverflow.com/questions/50411064/simpledateformat-with-german-locale-java-8-vs-java-10/50412644
 in the context of http://openjdk.java.net/jeps/252 with Java 9. It would 
probably be good to enforce either Java 8 or Java 11 for running the IT and 
don't allow the other version! Alternatively one can leverage the system 
property {{java.locale.providers=COMPAT}} to fall back even in Java 11 to the 
Java 8 behaviour.


was (Author: kwin):
It seems the formatting has changed 
https://stackoverflow.com/questions/50411064/simpledateformat-with-german-locale-java-8-vs-java-10/50412644
 in the context of http://openjdk.java.net/jeps/252 with Java 9. It would 
probably be good to enforce either Java 8 or Java 11 for running the IT and 
don't allow the other version!

> HTL Testing: Errors in date and currency formatting tests
> ---------------------------------------------------------
>
>                 Key: SLING-9984
>                 URL: https://issues.apache.org/jira/browse/SLING-9984
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: Scripting HTL Testing 1.0.28-1.4.0
>            Reporter: Konrad Windszus
>            Assignee: Radu Cotescu
>            Priority: Minor
>
> With Java 11 on Mac OS
> {code}
> mvn --version
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /usr/local/Cellar/maven/3.6.3/libexec
> Java version: 11.0.9.1, vendor: AdoptOpenJDK, runtime: 
> /Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home
> Default locale: en_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"
> {code}
>  I get the following errors when running {{mvn verify}} on 
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing
> {code}
> Running io.sightly.tck.TestsRunner
> Tests run: 518, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.977 sec 
> <<< FAILURE! - in io.sightly.tck.TestsRunner
> Expression Filters: @format - 
> #format-date-12(io.sightly.tck.tests.TestBuilder$1)  Time elapsed: 0.004 sec  
> <<< FAILURE!
> junit.framework.AssertionFailedError: Expected value 'Sonntag, 1 Dez 1918' 
> for selector '#format-date-12'. Instead we got 'Sonntag, 1 Dez. 1918'. Please 
> check the expected markup from /testfiles/output/exprlang/filters.html.
>       at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146)
> ...
> Expression Filters: @format - 
> #format-number-11(io.sightly.tck.tests.TestBuilder$1)  Time elapsed: 0.001 
> sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expected value 'CHF 1'000.14' for 
> selector '#format-number-11'. Instead we got 'CHF 1’000.14'. Please check the 
> expected markup from /testfiles/output/exprlang/filters.html.
>       at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146)
> Failed tests:
>   TestBuilder$1.runTest:146 Expected value 'Sonntag, 1 Dez 1918' for selector 
> '#format-date-12'. Instead we got 'Sonntag, 1 Dez. 1918'. Please check the 
> expected markup from /testfiles/output/exprlang/filters.html.
>   TestBuilder$1.runTest:146 Expected value 'CHF 1'000.14' for selector 
> '#format-number-11'. Instead we got 'CHF 1’000.14'. Please check the expected 
> markup from /testfiles/output/exprlang/filters.html.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to