[ 
https://issues.apache.org/jira/browse/SLING-8942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247286#comment-17247286
 ] 

Angela Schreiber commented on SLING-8942:
-----------------------------------------

[~kwin], [~karlpauls] , just an quick, ugly draft patch on how that could be 
addressed. i kept wondering, why the code parses the xml itself with hardcoded 
strings, when Jackrabbit fvault comes with utilities that actually do parse 
meta-info like privileges. maybe there is a reason for this, that i am not 
aware of... this definitely need to be checked. also, i couldn't find examples 
for content packages with abstract/aggregated privileges if jackrabbit 
fvault.... hope i got it right.

also spotted a bug in the test privileges.xml resource:
{code:java}
<privileges xmlns:crx="http://sling.apache.org/rx/1.0";>
   <privilege name="rx:replicate"/>
</privileges>{code}
the namespace prefix is garbled.... probably leftover from trying to disguise 
that this was just a copy from Adobe AEM....

> Support aggregate and abstract privileges
> -----------------------------------------
>
>                 Key: SLING-8942
>                 URL: https://issues.apache.org/jira/browse/SLING-8942
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.0.2
>            Reporter: Konrad Windszus
>            Priority: Critical
>             Fix For: Content-Package to Feature Model Converter 1.0.26
>
>         Attachments: SLING-8942.patch
>
>
> Currently only simple privileges are supported via 
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/ffc6bb990dfaf82c477a28ad4b87b0c12859b743/src/main/java/org/apache/sling/feature/cpconverter/handlers/PrivilegesHandler.java#L65.
>  Aggregate and abstract privileges should be supported as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to