[
https://issues.apache.org/jira/browse/SLING-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-9967.
-------------------------------
Resolution: Fixed
Done in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/43
[~angela], thanks again for the review and the report!
> AclManagerTest.makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths covers too
> many different scenarios
> ---------------------------------------------------------------------------------------------------
>
> Key: SLING-9967
> URL: https://issues.apache.org/jira/browse/SLING-9967
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
> Reporter: Angela Schreiber
> Assignee: Karl Pauls
> Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> {{AclManagerTest.makeSureAclsAreCreatedOnlyoutsideSytemUsersPaths}} should be
> refactored to cover just a single test scenario (matching the name of the
> method)
> despite the name of the test method it not only asserts that entries
> effective below/at the user home node are ignored (see SLING-9953 for the
> corresponding bug), but also covers entries at arbitrary paths as well as
> quote {{// add an ACL for unknown user}}, which IMHO doesn't belong here.
> to make things more confusing it additional add quote {{// emulate a second
> iteration of conversion}}, which IMHO is not clear why this is relevant for
> the original intended scenario.
> this just make any kind of bug fix or improvement of the code base extra hard
> as the test has too many different ways of failing. also, if SLING-9953 is
> fixed and the test gets removed, the other (legitimate) test-scenarios will
> also be gone without replacement.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
