stefanseifert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/pull/1#issuecomment-746612208
we already have similar features in jcr-mock: https://sling.apache.org/documentation/development/jcr-mock.html#mocking-queries with variant convenience methods setting directly a result with MockJcr.setQueryResult and addQueryResultHandler. but of course it would be nice to have a similar feature when using resourceresolver-mock. probably we should design the API ti apply the result or query handler in a similar fashion (with different signatures as only the Sling API is involved)? in any case i would propose to define an explicit interface instead of using a BiFuction which needs to lookup the JavaDocs to know which parameter is used for what. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
