kwin commented on a change in pull request #7:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/7#discussion_r547950832
##########
File path: src/main/java/org/apache/sling/servlets/post/SlingPostOperation.java
##########
@@ -69,6 +71,8 @@
* @param processors The {@link SlingPostProcessor} services to be called
* after applying the operation. This may be <code>null</code>
if
* there are none.
+ * @throws RetryableOperationException
Review comment:
when to expect which operation?
##########
File path:
src/main/java/org/apache/sling/servlets/post/exceptions/IncorrectInputException.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.servlets.post.exceptions;
+
+import org.apache.sling.api.resource.PersistenceException;
+
+
+/**
+ * Indicates that the input does not meet the necessary preconditions
required by JCR.
Review comment:
IMHO this should be agnostic of the underlying resource provider, i.e.
only mention JCR as one example.
##########
File path:
src/main/java/org/apache/sling/servlets/post/exceptions/IncorrectInputException.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.servlets.post.exceptions;
+
+import org.apache.sling.api.resource.PersistenceException;
+
+
+/**
+ * Indicates that the input does not meet the necessary preconditions
required by JCR.
+ * In that case the client should redo the request with a changed input.
+ *
+ */
+
+public class IncorrectInputException extends PersistenceException {
Review comment:
PreconditionViolationPersistenceException?
##########
File path:
src/main/java/org/apache/sling/servlets/post/exceptions/RetryableOperationException.java
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.servlets.post.exceptions;
+
+import org.apache.sling.api.resource.PersistenceException;
+
+
+/**
+ * This exceptions indicates errors, which might be temporary and for which a
retry
Review comment:
TemporaryPersistenceException instead of RetryableOperationException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
