karlpauls commented on a change in pull request #46:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/46#discussion_r556113669
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##########
@@ -268,7 +263,7 @@ private static void addAclStatement(Formatter formatter,
String systemUser, List
formatter.format("end%n");
}
- private static boolean areEmpty(List<AccessControlEntry> authorizations) {
+ private static boolean areEmpty(@Nullable List<AccessControlEntry>
authorizations) {
return authorizations == null || authorizations.isEmpty();
Review comment:
See above.
##########
File path:
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##########
@@ -268,7 +263,7 @@ private static void addAclStatement(Formatter formatter,
String systemUser, List
formatter.format("end%n");
}
- private static boolean areEmpty(List<AccessControlEntry> authorizations) {
+ private static boolean areEmpty(@Nullable List<AccessControlEntry>
authorizations) {
Review comment:
Yup, we should drop the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
