anchela opened a new pull request #47: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/47
@karlpauls , a few notes/questions regarding this PR (copied from jira): - the regex in the new RepRepoPolicyEntryHandler looks a rather ugly to me.... if you have a better idea on how to do this without changing too much of the logic in RepPolicyEntryHandler, please let me know. in Oak the rep:repoPolicy can only occur at the root node but the call to `matcher.group(1)` in AbstractPolicyParser forces a group in the regex - RepoPath: should isRepositoryPath be reflected in the equals/hashcode methods? - DefaultAclManager: the method getRepoInitPath introduced in the patch has a param SystemUser which is not used yet.... but will it be needed for SLING-9692 and SLING-9953. since i derived the patch from some initial work done for those issues i decided to leave it in. - TestUtils: i noticed that quite some test copy the logic on how to mock the fvault parts. i didn't yet replace all copies (just the one in the SystemUserHandlerTest). should i rather create a separate improvement for that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
