i've a problem running the unit test on windows - seems to be a line ending 
issue (see below).
another cosmetic remark: please put the SLING ticket number in the git commit 
messages, otherwise it's difficult to associate it.

stefan

-------------------------------------------------------------------------------
Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
-------------------------------------------------------------------------------
Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s <<< 
FAILURE! - in org.apache.sling.rewriter.impl.components.Html5SerializerTest
org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument 
 Time elapsed: 0.147 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<<!DOCTYPE html>[]
> but was:<<!DOCTYPE html>[
]
>
        at 
org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument(Html5SerializerTest.java:113)




>-----Original Message-----
>From: Daniel Klco <[email protected]>
>Sent: Friday, January 15, 2021 6:40 PM
>To: [email protected]
>Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
>
>Hi,
>
>We solved 9 issues in this release:
>https://issues.apache.org/jira/projects/SLING/versions/12342644
>
>I bumped to 1.3 due to the HTM5 serializer support which is backwards
>compatible.
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2399/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2399 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.

Reply via email to