karlpauls commented on a change in pull request #53:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#discussion_r560057954
##########
File path:
src/test/java/org/apache/sling/feature/cpconverter/handlers/GroupEntryHandlerTest.java
##########
@@ -70,4 +70,16 @@ public void parseUser() throws Exception {
TestUtils.createRepoInitExtension(handler, aclManager, path,
getClass().getResourceAsStream(path.substring(1)));
verify(aclManager, never()).addGroup(any(Group.class));
}
+
+ @Test
+ public void parseGroupWithConfig() throws Exception {
+ String path =
"/jcr_root/system/groups/g/V084LLw1ypl2l9G0e28c/.content.xml";
Review comment:
I think the tests are covering that - I did update the path
##########
File path:
src/test/java/org/apache/sling/feature/cpconverter/handlers/UsersEntryHandlerTest.java
##########
@@ -18,10 +18,7 @@
import org.apache.sling.feature.Extension;
import org.apache.sling.feature.ExtensionType;
-import org.apache.sling.feature.cpconverter.accesscontrol.AclManager;
-import org.apache.sling.feature.cpconverter.accesscontrol.DefaultAclManager;
-import org.apache.sling.feature.cpconverter.accesscontrol.SystemUser;
-import org.apache.sling.feature.cpconverter.accesscontrol.User;
+import org.apache.sling.feature.cpconverter.accesscontrol.*;
Review comment:
fixed
##########
File path:
src/test/java/org/apache/sling/feature/cpconverter/handlers/UsersEntryHandlerTest.java
##########
@@ -118,6 +115,18 @@ public void testUser() throws Exception {
verify(aclManager, never()).addSystemUser(any(SystemUser.class));
}
+ @Test
+ public void parseUserWithConfig() throws Exception {
+ String path = "/jcr_root/system/users/a/author/.content.xml";
Review comment:
see above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
