tomasalmeida commented on a change in pull request #10:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/10#discussion_r560506725
##########
File path:
src/main/java/org/apache/sling/servlets/post/impl/helper/SortedByRankingList.java
##########
@@ -0,0 +1,106 @@
+/*
Review comment:
Thank you for the feedback! I will rework on this PR and reimplement the
binding using the references given. I believe it is straightforward to
implement it for NodeNameGenerator, SlingPostProcessor and PostResponseCreator
lists.
Although, I need to rethink how to bind/unbind the postOperation based on
OperationName, as in the implementation we have a Map(operationName, List of
PostOperation services). Having one large list is not optimal and the map was
useful.
If any of you have an idea how I can solve the map problem, I accept
suggestions 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
