bdelacretaz commented on a change in pull request #17:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/17#discussion_r562630989
##########
File path:
src/main/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutor.java
##########
@@ -289,4 +332,71 @@ private String getDirectiveArgumentValue(Directive d,
String name) {
throw up;
}
}
+
+ GraphQLSchema getSchema(@NotNull String sdl, @NotNull Resource
currentResource, @NotNull String[] selectors) {
+ readLock.lock();
Review comment:
I think this can move to two lines later, just before
resourceToHashMap.get ? No need to lock while computing the hash etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
