kwin commented on a change in pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#discussion_r564752756
##########
File path:
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java
##########
@@ -163,6 +164,14 @@ public void processRepository(SlingRepository
slingRepository) throws Exception
builder.with(session);
ExecutionPlan xplan = builder.execute();
if (xplan.getTasks().size() > 0) {
+ if (xplan.hasErrors()) {
+ for (PackageTask task : xplan.getTasks()) {
+ if
(PackageTask.State.ERROR.equals(task.getState())){
+ logger.error("Error during
installation of {}: {}", task.getPackageId().toString(),
task.getError().toString());
Review comment:
Please rather add those as suppressed exceptions via
https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#addSuppressed(java.lang.Throwable)
to the ISE. They already get logged within
https://github.com/apache/jackrabbit-filevault/blob/beb4a72adcf963c1da6ed9604c18b8b5b69ee57c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/PackageTaskImpl.java#L113.
##########
File path: pom.xml
##########
@@ -42,37 +41,14 @@
</scm>
<build>
<plugins>
+ <plugin>
Review comment:
No need to explicitly list these plugins as they are activated in the
parent:
https://github.com/apache/sling-parent/blob/7e6567a003f670e179895b9000e294bc631bae18/sling-bundle-parent/pom.xml#L192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
