[
https://issues.apache.org/jira/browse/SLING-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jörg Hoh updated SLING-10107:
-----------------------------
Description:
In the 2 classes {{Bookkepper}} and the {{Localstore}} the creation of
ResourceResolvers is spread over multiple places, and also the number of
methods, where ResourceResolvers are opened for obviously tiny operations is
quite high.
Therefor I refactored the creation of ResourceResolvers for the subservice
bookkeeper (which is the majority of cases) and centralized the creation of it
into a central supplier within the {{Bookkeeper}}. I also added a new Gauge
metric to observe how often a new ResourceResolver is actually created.
My gut feeling is, that the number of creations is (too) high; but before I
start combining operations and reduce the number of ResourceResolver creations,
I would like to understand if it's a problem at all.
See
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/63
for the PR
was:
In the 2 classes {{Bookkepper}} and the {{Localstore}} the creation of
ResourceResolvers is spread over multiple places, and also the number of
methods, where ResourceResolvers are opened for obviously tiny operations is
quite high.
Therefor I refactored the creation of ResourceResolvers for the subservice
bookkeeper (which is the majority of cases) and centralized the creation of it
into a central supplier within the {{Bookkeeper}}. I also added a new Gauge
metric to observe how often a new ResourceResolver is actually created.
My gut feeling is, that the number of creations is (too) high; but before I
start combining operations and reduce the number of ResourceResolver creations,
I would like to understand if it's a problem at all.
> Refactoring of creation of ResourceResolvers
> --------------------------------------------
>
> Key: SLING-10107
> URL: https://issues.apache.org/jira/browse/SLING-10107
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
> Affects Versions: Content Distribution Journal Core 0.1.16
> Reporter: Jörg Hoh
> Priority: Major
>
> In the 2 classes {{Bookkepper}} and the {{Localstore}} the creation of
> ResourceResolvers is spread over multiple places, and also the number of
> methods, where ResourceResolvers are opened for obviously tiny operations is
> quite high.
> Therefor I refactored the creation of ResourceResolvers for the subservice
> bookkeeper (which is the majority of cases) and centralized the creation of
> it into a central supplier within the {{Bookkeeper}}. I also added a new
> Gauge metric to observe how often a new ResourceResolver is actually created.
> My gut feeling is, that the number of creations is (too) high; but before I
> start combining operations and reduce the number of ResourceResolver
> creations, I would like to understand if it's a problem at all.
> See
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/63
> for the PR
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
