[
https://issues.apache.org/jira/browse/SLING-9068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279735#comment-17279735
]
Angela Schreiber commented on SLING-9068:
-----------------------------------------
[~davidb], thanks for adjusting the fix version. can you confirm that the issue
will be addressed in RepoInit Parser 1.6.6? I just came across this again
yesterday, when having a failure with Apache Sling Feature Model Analyser in
the form of:
{code}
[INFO] Analyzing feature '...' finished : 1 warnings, 1 errors.
[ERROR] repoinit: Parsing error in repoinit from extension : Encountered "" at
line 15, column 37.
Was expecting one of:
[ERROR] Analyser detected errors on feature '...'. See log output for error
messages.
{code}
at a first glance i wanted to report an improvement request with the feature
model analyzer but then realized that the latter only outputs whatever is
coming from repo-init. and what is coming from repo-init is hard to read. in
this particular instance i wanted to test snapshot dependencies of repo-init in
Adobe AEM and concluded that this not possible without adjusting the
feature-model-analyser.... so the syntax was correct afaik but the parser used
in the analyser pointed to an older version (that's what i concluded).
> Add more context to ParseException
> ----------------------------------
>
> Key: SLING-9068
> URL: https://issues.apache.org/jira/browse/SLING-9068
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
> Affects Versions: Repoinit Parser 1.6.2
> Reporter: Angela Schreiber
> Priority: Minor
> Fix For: Repoinit Parser 1.6.6
>
>
> today the repo init grammar doesn't come with dedicated exception handing and
> thus the parser will fail with messages that can make it hard to spot actual
> problem... specially in a lengthy repo-init as it is present with Adobe AEM.
> Example:
> {code}
> org.apache.sling.repoinit.parser.impl.ParseException: Encountered " "," ", ""
> at line 115, column 46.
> Was expecting:
> ")" ...
>
> at
> org.apache.sling.repoinit.parser.impl.RepoInitParserImpl.generateParseException(RepoInitParserImpl.java:3095)
> [org.apache.sling.repoinit.parser:1.3.2]
> {code}
> if i am not mistaken this should be doable be adding explicit exceptions to
> the grammar.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
