[
https://issues.apache.org/jira/browse/SLING-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10127:
------------------------------------
Description:
Currently in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/a21667f65a2bd503bd752c3cc6fb842caac90d90/src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java#L343
all generated/modified content packages of type "content" are just disregarded.
If you have as input a content package of type "content" containing ACLs on
mutable nodes, system users and arbitrary other mutable nodes, the first two
are correctly extracted into a feature model but the content package is not
modified, leading to the fact that the ACLs and system users are still
contained in the content package.
IMHO a modified content-package should be given out (and kept) as that one
differs from the input content package!
Otherwise you would try to install system users/ACLs again when installing the
content package.
was:
Currently in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/a21667f65a2bd503bd752c3cc6fb842caac90d90/src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java#L343
all generated/modified content packages of type "content" are just disregarded.
If you have as input a content package of type "content" containing ACLs on
mutable nodes, system users and arbitrary other mutable nodes, the first two
are correctly extracted into a feature model but the content package is not
modified, leading to the fact that the ACLs and system users are still
contained in the content package.
IMHO a modified content-package should be given out (and kept) as that one
differs from the input content package!
> Keep modified content packages of type "content"
> ------------------------------------------------
>
> Key: SLING-10127
> URL: https://issues.apache.org/jira/browse/SLING-10127
> Project: Sling
> Issue Type: Improvement
> Components: Feature Model
> Affects Versions: Content-Package to Feature Model Converter 1.0.24
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently in
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/a21667f65a2bd503bd752c3cc6fb842caac90d90/src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java#L343
> all generated/modified content packages of type "content" are just
> disregarded.
> If you have as input a content package of type "content" containing ACLs on
> mutable nodes, system users and arbitrary other mutable nodes, the first two
> are correctly extracted into a feature model but the content package is not
> modified, leading to the fact that the ACLs and system users are still
> contained in the content package.
> IMHO a modified content-package should be given out (and kept) as that one
> differs from the input content package!
> Otherwise you would try to install system users/ACLs again when installing
> the content package.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
