Thank you for the insights. I will make suggested changes and update the PR.
Regards Akanksha Jain On 2021/02/10 10:46:47, Robert Munteanu <[email protected]> wrote: > Hi, > > On Tue, 2021-02-09 at 14:06 +0100, Carsten Ziegeler wrote: > > Any opinions or comments on the suggested change? > > > > Regards > > Carsten > > > > Am 08.02.2021 um 14:02 schrieb Akanksha: > > > Hi Developers > > > > > > I was working on JIRA SLING-9741. > > > Related PR: > > > https://github.com/apache/sling-org-apache-sling-engine/pull/11 > > > > > > Approach: Mark Request invalid if it contains continuous dots. > > > > > > Request you all to review my approach or is there any better > > > approach to address this issue > > As noted in the PR, I'm a bit in unfamiliar territory so take this with > a grain of salt. > > The only high-level change I would suggest is to make make this the > first check and return a 400, as I think it fits the condition better. > > Thanks, > Robert > >
