[ 
https://issues.apache.org/jira/browse/SLING-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289682#comment-17289682
 ] 

Carsten Ziegeler commented on SLING-10157:
------------------------------------------

The order of paths in a zip file is not reliable, it depends on the tool 
creating the zip file and the order the tool creates the entries. So this is 
not a stable order.
I think the first step is to implement this like the OSGi installer does, and 
that is based on the path order - that should be the default.
I'm not sure if anyone is using the mergeConfiguration flag - at least the way 
it is implemented today, it does not have a stable order either.
I'm open to implement other strategies, but I think thats an extension to the 
current mechanism.
Or in other words, lets
1. fix the broken implementation (this issue)
2. think about extensions (another issue)

> Converter fails with duplicate configuration PIDs
> -------------------------------------------------
>
>                 Key: SLING-10157
>                 URL: https://issues.apache.org/jira/browse/SLING-10157
>             Project: Sling
>          Issue Type: Bug
>          Components: Content-Package to Feature Model Converter
>    Affects Versions: Content-Package to Feature Model Converter 1.0.24
>            Reporter: Carsten Ziegeler
>            Priority: Major
>             Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> If there is a configuration for the same PID multiple times, either in the 
> same or different content packages, the converter fails with an error.
> We should handle this similar to how the OSGi installer does it, and pick the 
> right configuration based on the repository path.
> A warning should be logged for these cases as well.
> We could add a strict option, throwing an exception in this case like today



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to