[ 
https://issues.apache.org/jira/browse/SLING-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290037#comment-17290037
 ] 

Muzaffar Nurmukhammadov commented on SLING-10159:
-------------------------------------------------

[~cziegeler] Small UnitTest would not be sufficient here, but I am not aware of 
how one can run Integration Tests using *sling-feature-launcher.* We use 
*pax-container-native*, but this is not the case here. If there is a sample 
IntegrationTest that runs on *sling-feature-launcher* I would be appreciated if 
you can point me to. 

 

Our use case is really simple, we defined 
*org.osgi.framework.startlevel.beginning* in the *feature.json* and we want to 
control this property. But since it retrieves the empty map and assigns the 
default property value, our value is ignored here. 

!Capture.PNG|width=1094,height=211!

> Handle framework properties after the feature is processed
> ----------------------------------------------------------
>
>                 Key: SLING-10159
>                 URL: https://issues.apache.org/jira/browse/SLING-10159
>             Project: Sling
>          Issue Type: Bug
>          Components: Feature Model
>            Reporter: Muzaffar Nurmukhammadov
>            Priority: Major
>             Fix For: Feature Model Launcher 1.1.18
>
>         Attachments: 108997486-f0659980-769f-11eb-8cd4-db3f84f1b797.png, 
> Capture.PNG
>
>
> [https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/15]
>  
> OSGi properties are being handled before 
> {{_Installation#getFrameworkProperties()_}} is populated by parsing the 
> Feature files using _{{FeatureProcessor#prepareLauncher()}}_.
> E.g. specifying framework properties such as 
> *org.osgi.framework.startlevel.beginning* and *org.osgi.framework.storage* in 
> *feature.json* file has no effect, the default values are used. These 
> properties should be read from the feature
>  
> In the *{{prepare()}}* method *{{installation.getFrameworkProperties()}}* is 
> empty.
> !108997486-f0659980-769f-11eb-8cd4-db3f84f1b797.png|width=424,height=274!
> The duplicate code exists in the *{{run()}}* method, which is correct.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to